Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of the application #89

Merged
merged 9 commits into from
Apr 1, 2024
Merged

Cleanup of the application #89

merged 9 commits into from
Apr 1, 2024

Conversation

philippzagar
Copy link
Contributor

@philippzagar philippzagar commented Mar 31, 2024

Cleanup of the application

♻️ Current situation & Problem

As of now, the application is quite cluttered and lots of dead code exists. The reason for this is the prioritization of features during the CS342 class

⚙️ Release Notes

  • Final Cleanup of the application

📚 Documentation

--

✅ Testing

Manually tested the application, ensure that UI tests are still passing

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Mar 31, 2024
@philippzagar philippzagar self-assigned this Mar 31, 2024
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 45.48803% with 296 lines in your changes are missing coverage. Please review.

Project coverage is 49.89%. Comparing base (93097c7) to head (55c354e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   43.30%   49.89%   +6.60%     
==========================================
  Files          61       51      -10     
  Lines        3751     3083     -668     
==========================================
- Hits         1624     1538      -86     
+ Misses       2127     1545     -582     
Files Coverage Δ
Intake/AllergyView/AddAllergy.swift 100.00% <ø> (ø)
Intake/AllergyView/AllergyRecords.swift 63.25% <100.00%> (ø)
Intake/AllergyView/ReactionPDF.swift 0.00% <ø> (ø)
Intake/AllergyView/ReactionSectionView.swift 75.00% <ø> (ø)
Intake/AllergyView/ReactionView.swift 0.00% <ø> (ø)
Intake/ChiefComplaintView/LLMOnboardingView.swift 0.00% <ø> (ø)
...omplaintView/OpenAI/LLMOpenAITokenOnboarding.swift 0.00% <ø> (ø)
Intake/ChiefComplaintView/SummaryView.swift 0.00% <ø> (ø)
Intake/Helper/ViewElements.swift 72.10% <ø> (ø)
Intake/Intake.swift 100.00% <100.00%> (+1.86%) ⬆️
... and 32 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93097c7...55c354e. Read the comment docs.

@philippzagar philippzagar enabled auto-merge (squash) March 31, 2024 21:33
@philippzagar philippzagar changed the title Final Cleanup of the application Cleanup of the application Apr 1, 2024
Copy link
Contributor

@kcallon kcallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!!

@philippzagar philippzagar merged commit f9689d7 into main Apr 1, 2024
7 checks passed
@philippzagar philippzagar deleted the feat/cleanup branch April 1, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants